feat: add new prop to TabView for better keyboard handling #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hey, thank you for opening a new PR and working on this. I think I found root cause of your issue and fixed it in this PR: #269 can you take a look? |
Author
|
I tested it and can confirm your pr solves the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature to handle the keyboard safe area in the
react-native-bottom-tabspackage. The changes include updates to both the iOS implementation and the TypeScript interfaces to support this feature. See #255PR Description
iOS Implementation:
TabViewImpl.swift: Added a condition to ignore the keyboard safe area based on a new propertyignoresKeyboardSafeArea.TabViewProps.swift: Introduced a new published propertyignoresKeyboardSafeAreato manage the keyboard safe area behavior.TabViewProvider.swift: Added a new propertyignoresKeyboardSafeAreawith an observer to update related properties.TypeScript Interfaces:
TabView.tsx: Added a new propignoresKeyboardSafeAreawith a default value and passed it to the native component. [1] [2] [3]TabViewNativeComponent.ts: Updated theTabViewPropsinterface to include the newignoresKeyboardSafeAreaproperty.How to test?
Screenshots
Before:
https://github.com/user-attachments/assets/956cd05b-66e9-4b71-ac23-fdeb7fd52af8
After:
https://github.com/user-attachments/assets/7a376818-6e8a-4e63-8d15-654d8d650bbb